MegaBites-AI/Windows-powershell

1# Repository Maintainers2 3Repository Maintainers are trusted stewards of the PowerShell repository responsible for maintaining consistency and quality of PowerShell code.4One of their primary responsibilities is merging pull requests after all requirements have been fulfilled.5 6They have [write access](https://docs.github.com/en/free-pro-team@latest/github/setting-up-and-managing-organizations-and-teams/repository-permission-levels-for-an-organization) to the PowerShell repositories which gives them the power to:7 81. `git push` to the official PowerShell repository91. Merge [pull requests](https://docs.github.com/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/about-pull-requests)101. Assign labels, milestones, and people to [issues](https://guides.github.com/features/issues/) and [pull requests](https://docs.github.com/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/about-pull-requests)11 12## Table of Contents13 14- [Current Repository Maintainers](#current-repository-maintainers)15- [Repository Maintainer Responsibilities](#repository-maintainer-responsibilities)16- [Issue Management Process](#issue-management-process)17- [Pull Request Workflow](#pull-request-workflow)18- [Becoming a Repository Maintainer](#becoming-a-repository-maintainer)19 20## Current Repository Maintainers21 22<!-- please keep in alphabetical order -->23 24- Aditya Patwardhan ([adityapatwardhan](https://github.com/adityapatwardhan))25- Andrew Menagarishvili ([anmenaga](https://github.com/anmenaga))26- Dongbo Wang ([daxian-dbw](https://github.com/daxian-dbw))27- Ilya Sazonov ([iSazonov](https://github.com/iSazonov))28- Robert Holt ([rjmholt](https://github.com/rjmholt))29- Travis Plunk ([TravisEz13](https://github.com/TravisEz13))30 31## Former Repository Maintainers32 33<!-- please keep in alphabetical order -->34 35- Andy Jordan ([andyleejordan](https://github.com/andyleejordan))36- Jason Shirk ([lzybkr](https://github.com/lzybkr))37- Mike Richmond ([mirichmo](https://github.com/mirichmo))38- Sergei Vorobev ([vors](https://github.com/vors))39 40## Repository Maintainer Responsibilities41 42Repository Maintainers enable rapid contributions while maintaining a high level of quality in PowerShell by ensuring that all development processes are being followed correctly.43 44If you are a Repository Maintainer, you:45 461. **MUST** abide by the [Code of Conduct](../../CODE_OF_CONDUCT.md) and report suspected violations to the [PowerShell Committee][ps-committee]471. **MUST** ensure that each contributor has signed a valid Microsoft Contributor License Agreement (CLA)481. **MUST** verify compliance with any third party code license terms (e.g., requiring attribution, etc.) if the contribution contains third party code.491. **MUST** make sure that [any change requiring approval from the PowerShell Committee](../community/governance.md#changes-that-require-an-rfc) has gone through the proper [RFC][RFC-repo] or approval process501. **MUST** validate that code reviews have been conducted before merging a pull request when no code is written511. **MUST** validate that tests and documentation have been written before merging a pull request that contains new functionality521. **SHOULD** add [the correct labels][issue-management] to issues and pull requests531. **SHOULD** make sure the correct [Area Experts](../community/governance.md#area-experts) are assigned to relevant pull requests and issues.54  This includes adding extra reviewers when it makes sense55  (e.g. a pull request that adds remoting capabilities might require a security expert)561. **SHOULD** validate that the names and email addresses in the git commits reasonably match identity of the person submitting the pull request571. **SHOULD** make sure contributors are following the [contributor guidelines][CONTRIBUTING]581. **SHOULD** ask people to resend a pull request, if it [doesn't target `master`](../../.github/CONTRIBUTING.md#lifecycle-of-a-pull-request)591. **SHOULD** wait for the [CI system][ci-system] build to pass for pull requests60  (unless, for instance, the pull request is being submitted to fix broken CI)611. **SHOULD** encourage contributors to refer to issues in their pull request description (e.g. `Resolves issue #123`).62  If a user did not create an issue prior to submitting their pull request, their pull request should not be rejected.63  However, they should be reminded to create an issue in the future to frontload any potential problems with the work and to minimize duplication of efforts.641. **SHOULD** encourage contributors to create meaningful titles for all PRs.65  Edit the title if necessary to provide clarity on the problem661. **SHOULD** encourage contributors to write meaningful, descriptive git commits671. **SHOULD NOT** merge pull requests with a failed CI build68  (unless, for instance, the pull request is being submitted to fix broken CI)691. **SHOULD NOT** merge pull requests without the status check passing from the Microsoft CLA bot70  (unless the CLA bot is broken, and CLA signing can be confirmed through other means)711. **SHOULD NOT** merge pull requests too quickly after they're submitted.72  Even if the pull request meets all the requirements, people should have time to give their input73  (unless the pull request is particularly urgent for some reason)741. **SHOULD NOT** merge your own pull requests.75  If a Repository Maintainer opens a pull request, another Maintainer should merge it unless there are extreme, short-term circumstances requiring a merge or another Maintainer has given explicit sign-off without merging76 77## Issue Management Process78 79Please see [Issue Management][issue-management]80 81## Pull Request Workflow82 83Please see [Contributing][CONTRIBUTING]84 85## Maintainer Best Practices86 87Please see [Best Practices][best-practice]88 89## Becoming a Repository Maintainer90 91Repository Maintainers currently consist mostly of Microsoft employees.92It is expected that over time, regular trusted contributors to the PowerShell repository will be made Repository Maintainers.93Eligibility is heavily dependent on the level of contribution and expertise: individuals who contribute consistently in meaningful ways to the project will be recognized accordingly.94 95At any point in time, the existing Repository Maintainers can unanimously nominate a strong community member to become a Repository Maintainer.96Nominations are brought to the PowerShell Committee to understand the reasons and justification.97A simple majority of the PowerShell Committee is required to veto the nomination.98When a nominee has been approved, a PR will be submitted by a current Maintainer to update this document to add the nominee's name to99the [Current Repository Maintainers](#current-repository-maintainers) with justification as the description of the PR to serve as the public announcement.100 101[RFC-repo]: https://github.com/PowerShell/PowerShell-RFC102[ci-system]: ../testing-guidelines/testing-guidelines.md#ci-system103[issue-management]: issue-management.md104[CONTRIBUTING]: ../../.github/CONTRIBUTING.md105[best-practice]: best-practice.md106[ps-committee]: ../community/governance.md#powershell-committee107